Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Restructure models and schemas #963

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

mferrera
Copy link
Collaborator

@mferrera mferrera commented Jan 9, 2025

Resolves #908
Stacked on #962

This funnels schemas, products, and non-export related models into _models, with a few little clean-ups along the way. The idea is that everything in this directory is largely static. It's where we change the schemas or add new ones, bump the versions, etc. Clear and cleanly separated away from runtime function, with the possibility of abstracting them out to their own repository if need be.

@mferrera mferrera self-assigned this Jan 9, 2025
@mferrera mferrera marked this pull request as ready for review January 9, 2025 13:41
@mferrera mferrera force-pushed the restructure-schema-models branch 2 times, most recently from add6e7b to 81ac13d Compare January 10, 2025 11:07
@mferrera mferrera force-pushed the restructure-schema-models branch from 81ac13d to 7e491b3 Compare January 13, 2025 09:45
@mferrera mferrera requested a review from tnatt January 13, 2025 09:46
Copy link
Collaborator

@tnatt tnatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mferrera mferrera merged commit e82dbe9 into equinor:main Jan 13, 2025
16 checks passed
@mferrera mferrera deleted the restructure-schema-models branch January 13, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema versioning: Give the fmu_results.json schema a better title
2 participants