Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add release logic to 'update-schema' #958

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

mferrera
Copy link
Collaborator

@mferrera mferrera commented Jan 8, 2025

Resolves #907
Stacked on #957

This will cause the schemas to overwrite with an updated $id field, but
only if nothing else has changed. It is also tested in GitHub Actions.

See https://github.com/equinor/fmu-dataio/actions/runs/12671501765/job/35313394311?pr=960#step:6:13 for how this looks when trying to merge a non-release version of the schema into the staging branch.

When preparing a PR for the release branch, you just need to run SCHEMA_RELEASE=1 ./tools/update-schema

@mferrera mferrera force-pushed the update-update-schema branch 9 times, most recently from 6603e1f to 88bf383 Compare January 8, 2025 12:03
@mferrera mferrera marked this pull request as ready for review January 8, 2025 12:10
@mferrera mferrera self-assigned this Jan 8, 2025
@mferrera mferrera force-pushed the update-update-schema branch from 88bf383 to 0121643 Compare January 8, 2025 13:12
@mferrera mferrera changed the title ENH: Add '--release' flag to 'update-schema' ENH: Add release logic to 'update-schema' Jan 8, 2025
@mferrera
Copy link
Collaborator Author

mferrera commented Jan 8, 2025

Originally went with --release but this struggles with the environment variable oriented way the schema URLs are determined. In some ways it's a bit nicer to manage this with an environment variable, so the adjusted worklflow just sets the environment variable before running the update-schema tool.

Copy link
Collaborator

@jcrivenaes jcrivenaes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

This will cause the schemas to overwrite with an updated $id field, but
only if nothing else has changed. It is also tested in GitHub Actions.
@mferrera mferrera force-pushed the update-update-schema branch from 0121643 to 06aa742 Compare January 9, 2025 11:10
@mferrera mferrera merged commit 5c49f6e into equinor:main Jan 9, 2025
16 checks passed
@mferrera mferrera deleted the update-update-schema branch January 9, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema versioning: Use -dev Radix url in main, -prod in staging and prod
2 participants