Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Validate schema with AJV #941

Merged
merged 1 commit into from
Dec 31, 2024
Merged

CI: Validate schema with AJV #941

merged 1 commit into from
Dec 31, 2024

Conversation

mferrera
Copy link
Collaborator

Resolves #938

@mferrera mferrera self-assigned this Dec 19, 2024
@mferrera mferrera marked this pull request as ready for review December 19, 2024 12:09
@mferrera
Copy link
Collaborator Author

mferrera commented Dec 19, 2024 •
edited
Loading

Checks failing to show that this step does catch failures. Will drop the DROPME commit after review so that things pass again.

slangeveld
slangeveld approved these changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@slangeveld slangeveld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mferrera mferrera merged commit 48313af into equinor:main Dec 31, 2024
15 checks passed
@mferrera mferrera deleted the validate-with-ajv branch December 31, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slangeveld slangeveld slangeveld approved these changes

@tnatt tnatt Awaiting requested review from tnatt

@joargr joargr Awaiting requested review from joargr

Assignees

@mferrera mferrera

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: Validate schema with AJV in a ci step
2 participants
@mferrera @slangeveld