Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add fmu.realization.is_reference to schema #832

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

tnatt
Copy link
Collaborator

@tnatt tnatt commented Oct 3, 2024

closes #826

@tnatt tnatt force-pushed the is_reference branch 3 times, most recently from 73135f1 to 19c38a2 Compare October 3, 2024 13:40
Copy link
Member

@perolavsvendsen perolavsvendsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment. If this populates the fmu.realization.is_reference in all data objects produced (of any class), and defaults it to False, this will probably create problems down the line - or we would have to iterate through all data objects in a realization and change all of them upon flagging a realization as "reference".

src/fmu/dataio/_model/fields.py Outdated Show resolved Hide resolved
@jcrivenaes
Copy link
Collaborator

jcrivenaes commented Oct 4, 2024

I have still issues with the wording here. Tried to have a discussion under the issue here: https://github.com/equinor/sumo/issues/153.

Key message: propose an off-line discussion @perolavsvendsen, @tnatt

@tnatt
Copy link
Collaborator Author

tnatt commented Oct 4, 2024

I have still issues with the wording here. Tried to have a discussion under the issue here: equinor/sumo#153.

Key message: propose an off-line discussion @perolavsvendsen, @tnatt

Yes lets do it! I am e.g. available after lunch today 🙂

Copy link
Collaborator

@mferrera mferrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on our discussion last week I believe this is good to go

@mferrera mferrera dismissed perolavsvendsen’s stale review October 8, 2024 05:42

I think this has been resolved now, but happy to be corrected if not (blocks being merged)

@tnatt tnatt force-pushed the is_reference branch 2 times, most recently from 38abd6a to 0d80677 Compare October 8, 2024 08:15
@tnatt tnatt merged commit acb2f25 into equinor:main Oct 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Add reference flag to realization block
4 participants