ENH: Do not call generate_metadata() on export when config is not valid #793
Conversation
tnatt
force-pushed
the
config_invalid_behaviour
branch
from
b79e525 to
0fbf4af
Compare
|
Still export data (without metadata)? |
Yes, no change in today's functionality. Simply a refactoring to find the export path to the object without having to create metadata first. This way we can avoid several checks of the validity of the config, and align the pydantic model used to generate metadata more to the one used for the schema. + users not interested in metadata won't get annoyed by validation errors 👍 So to be clear today we do a pure export of the object if the config is not valid, i.e. no metadata is exported. This is not changed here 🙂 |
tnatt
force-pushed
the
config_invalid_behaviour
branch
6 times, most recently
from
e83d1fb to
68bd6b9
Compare
tnatt
force-pushed
the
config_invalid_behaviour
branch
from
68bd6b9 to
37a24cc
Compare
tnatt
changed the title
| if not newsettings: | ||
| return | ||
|
|
||
| warnings.warn( |
There was a problem hiding this comment.
this warning was just moved since we need to run this _update_check_settings several places. The entire function can be removed once we move towards fmu.dataio 3.0
| outfile = Path(metadata["file"]["absolute_path"]) | ||
| # create output folders if they don't exist | ||
| outfile.parent.mkdir(parents=True, exist_ok=True) |
There was a problem hiding this comment.
Moved inside export_file
| @@ -308,16 +397,19 @@ def test_rep_include(globalconfig1, regsurf): | |||
| mymeta = exp.generate_metadata(regsurf) | |||
| assert mymeta["access"]["ssdl"]["rep_include"] is True | |||
|
|
|||
| # test that rep_include is taken from config if not provided | |||
| # test that rep_include is defaulted to false if not provided | |||
There was a problem hiding this comment.
Updated this test since rep_include no longer is included in the config by default
tnatt
force-pushed
the
config_invalid_behaviour
branch
from
37a24cc to
063c027
Compare
Was just in the process of entering it into the migration guide 🙂 should be there now! |
tnatt
force-pushed
the
config_invalid_behaviour
branch
from
063c027 to
40db19a
Compare
tnatt
changed the title
tnatt
force-pushed
the
config_invalid_behaviour
branch
from
40db19a to
d12c2f8
Compare
Closes #602
exportfunction and the config is not valid (i.e. no metadata should be exported)generate_metadatafunction saying in the future no metadata will be returned if the config is invalidgenerate_export_metadata,and removemasterdataandaccessas optional fields in the pydantic model used to generate metadata.