ENH: Add realization and iteration object metadata definitions #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
equinor-ruaj
force-pushed
the
realization-and-iteration-object-metadata
branch
2 times, most recently
from
9ad9383 to
01aee5c
Compare
equinor-ruaj
commented
Sep 19, 2024
equinor-ruaj
force-pushed
the
realization-and-iteration-object-metadata
branch
from
01aee5c to
13d5786
Compare
tnatt
reviewed
Sep 19, 2024
equinor-ruaj
force-pushed
the
realization-and-iteration-object-metadata
branch
2 times, most recently
from
75d44d2 to
81b2d3a
Compare
tnatt
reviewed
Sep 19, 2024
tnatt
reviewed
Sep 19, 2024
equinor-ruaj
force-pushed
the
realization-and-iteration-object-metadata
branch
from
81b2d3a to
ae2063c
Compare
tnatt
reviewed
Sep 19, 2024
mferrera
reviewed
Sep 20, 2024
There was a problem hiding this comment.
Not much to add beyond what @tnatt has covered. I worry that FMUIteration being fmu and not fmu.iteration reads a bit confusingly but cannot think of any improvements over it that still align with the way we've named other things.
I think it will be good to go when FMURealization.context is settled
tnatt
reviewed
Sep 20, 2024
equinor-ruaj
force-pushed
the
realization-and-iteration-object-metadata
branch
from
1f742c1 to
a565fa0
Compare
equinor-ruaj
force-pushed
the
realization-and-iteration-object-metadata
branch
from
78cfdae to
369994a
Compare
tnatt
reviewed
Sep 20, 2024
tnatt
reviewed
Sep 20, 2024
tnatt
approved these changes
Sep 20, 2024
equinor-ruaj
force-pushed
the
realization-and-iteration-object-metadata
branch
from
5e90fd6 to
821be9e
Compare
ErichSuter
pushed a commit
that referenced
this pull request
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving #774
Adding:
IterationMetadatathat requiresclass = iterationfmu.context.stage = casefmu.iterationmust existRealizationMetadatathat requiresclass = realizationfmu.context.stage = iterationfmu.iterationandfmu.realizationmust exist