Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Do not convert alias as string to list of characters #776

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

tnatt
Copy link
Collaborator

@tnatt tnatt commented Sep 6, 2024

Resolves #775

Also added deprecation warnings so that we in the future can get rid of the entire field_validator here

@tnatt tnatt requested review from mferrera and slangeveld September 6, 2024 09:57
@tnatt tnatt self-assigned this Sep 6, 2024
@tnatt tnatt force-pushed the bugfix_alias branch 2 times, most recently from 04c7dd8 to b421d7c Compare September 6, 2024 19:58
@tnatt tnatt added the bug Something isn't working label Sep 6, 2024
@tnatt tnatt requested a review from jcrivenaes September 9, 2024 08:22
Copy link
Contributor

@slangeveld slangeveld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 😊 Interesting to see how the field_validator can be used with Pydantic

@tnatt tnatt merged commit d42ad9c into equinor:main Sep 9, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix alias input as string is converted to list of characters
2 participants