BUG: Preserve top/base/offset information from config #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added one extra commit to allow a bit more freedom in the config file, and allow top and base to be given in as strings. I suspect there might be some set-ups where this is the case (also evident from the type hints on the This could later be deprecated with some information of what needs to change, currently a cryptic pydantic validation error comes telling people to use a dict input or a |
mferrera
approved these changes
Sep 4, 2024
Comment on lines
-36
to
-37
| @dataclass | ||
| class NamedStratigraphy: |
tnatt
force-pushed
the
strat_bug
branch
2 times, most recently
from
aad5d23 to
6c46557
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #772
The
top/base/offsetinformation was dropped after roundtripping with pydantic since these fields were not defined in theGlobalConfigurationModel.Also removed the
NamedStratigraphydataclass, as it is obsolete and can be replaced by theglobal_configuration.StratigraphyElement