Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Build datastructure documentation #431

Merged
merged 1 commit into from
Jan 26, 2024
Merged

DOC: Build datastructure documentation #431

merged 1 commit into from
Jan 26, 2024

Conversation

janbjorge
Copy link
Contributor

@janbjorge janbjorge commented Jan 25, 2024

Addresses #423

@janbjorge janbjorge self-assigned this Jan 25, 2024
@janbjorge
Copy link
Contributor Author

Seems to work OK, needs some tweaks to make it less noisy imo.

Screenshot 2024-01-26 at 09 53 16

Copy link
Member

@perolavsvendsen perolavsvendsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good start. It is producing documentation from the code. We need to work on the readability of this, but having the documentation built will also make it easier to restructure for readability.

It is an open question to me if we should work further on this now, or merge this - then do incremental changes (perhaps make a plan for that part as well before leaping into it) but I am leaning towards merging it.

@jcrivenaes opinions?

@janbjorge janbjorge marked this pull request as ready for review January 26, 2024 11:44
@janbjorge janbjorge changed the title Experimental: sphinx pydantic DOC: Build datastructure documentation Jan 26, 2024
@@ -0,0 +1,32 @@
# Tool for building the datastructure.rst file.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully we can find a way round using this script, but for now i have not found a way.

@janbjorge janbjorge merged commit bdf5291 into equinor:main Jan 26, 2024
12 checks passed
@janbjorge janbjorge deleted the sphinx-pydantic branch January 26, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants