FIX: Remove deprecated verbosity from examples
#427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example scripts generated warnings about passing the deprecated `verbosity` keyword to dataio and the docs also referenced it. The scripts were modified to set the logging level to `WARNING` which seems a reasonable example for users to follow as INFO may be more than they care about.
mferrera
commented
Jan 24, 2024
Comment on lines
219
to
+220
| -- as comments by ERT if not wrapped in quotes. This is the syntax to use: | ||
| -- (existing arguments) "--sumo" "--sumo_env" dev "--verbosity" DEBUG | ||
| -- (existing arguments) "--sumo" "--sumo_env" dev |
There was a problem hiding this comment.
This has already been removed from the example in Drogon
|
A general question: in the example case, realization 0 has more stuff than the other realizations, e.g. it has |
janbjorge
reviewed
Jan 24, 2024
| @@ -96,6 +96,8 @@ venv.bak/ | |||
|
|
|||
| # setuptools_scm version | |||
| src/fmu/dataio/version.py | |||
| # aggregated examples directory | |||
| examples/s/d/nn/xcase/iter-0/ | |||
There was a problem hiding this comment.
I think this should be moved out of this repository. As others will start to rely upon this repository will be anying for them that we "blot" it with unnecessary files (~90mb).
janbjorge
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example scripts generated warnings about passing the deprecated
verbositykeyword and the docs also referenced it. The scripts were modified to set the logging level toWARNINGwhich seems a reasonable example for users to follow as INFO may be more than they care about.