Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map classification from ssdl.access_level #324

Merged
merged 11 commits into from
Mar 15, 2023

Conversation

perolavsvendsen
Copy link
Member

@perolavsvendsen perolavsvendsen commented Mar 6, 2023

Lighter first step implementation of #295 based on discussions in #320

  • Make fmu-dataio be strict on the content of access.ssdl.access_level ["internal", "restricted", "asset].
    • We will deprecate "asset" at some point (soon).
    • We allow for the legacy value "asset" for now, translate it to "restricted" and issue warning.
    • We raise if content is not valid (new functionality).
  • Make fmu-dataio produce access.classification with the same value as access.ssdl.access_level in preparations for later deprecation of access.ssdl.access_level

@perolavsvendsen
Copy link
Member Author

perolavsvendsen commented Mar 7, 2023

Discussions with SSDL - they are OK with changing from "internal"/"asset" to "internal"/"restricted" in the access.ssdl.access_level field. Possibly, we should allow both "restricted" and "asset" in a transition period, with deprecation warning on "asset".

So we possibly include:

  • If "asset" is provided to access.ssdl.access_level, change it to "restricted" and issue warning.
  • Then map access.classification from the updated access.ssdl.access_level

Copy link
Collaborator

@jcrivenaes jcrivenaes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good so far

@perolavsvendsen perolavsvendsen marked this pull request as ready for review March 14, 2023 12:06
@perolavsvendsen
Copy link
Member Author

@rwiker @daniel-sol FYI

Copy link
Collaborator

@jcrivenaes jcrivenaes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@perolavsvendsen perolavsvendsen merged commit d7a937b into equinor:main Mar 15, 2023
@perolavsvendsen perolavsvendsen deleted the 295-light-implementation branch March 15, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants