Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dependencies keyword on aggregation vs realization #265

Merged
merged 3 commits into from
Nov 3, 2022
Merged

Use dependencies keyword on aggregation vs realization #265

merged 3 commits into from
Nov 3, 2022

Conversation

perolavsvendsen
Copy link
Member

@perolavsvendsen perolavsvendsen commented Nov 3, 2022 •
edited
Loading

Solve problem with using the not keyword directly. Trying the dependencies keyword instead. The intention is to allow either fmu.realization, fmu.aggregation or none of them - never both.

rwiker
rwiker approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@rwiker rwiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Seems to solve the startup problem with sumo-core.

@perolavsvendsen perolavsvendsen merged commit e11cd39 into equinor:main Nov 3, 2022
@perolavsvendsen perolavsvendsen deleted the schema_agg_real_bug branch November 3, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwiker rwiker rwiker approved these changes

@jcrivenaes jcrivenaes Awaiting requested review from jcrivenaes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@perolavsvendsen @rwiker