Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default localization pose #2012

Merged
merged 4 commits into from
Feb 7, 2025
Merged

Remove default localization pose #2012

merged 4 commits into from
Feb 7, 2025

Conversation

Eddasol
Copy link
Contributor

@Eddasol Eddasol commented Feb 6, 2025 •
edited
Loading

Depends on: #2011

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

🔔 Migrations changes detected 🔔
📣 Remember to comment "/UpdateDatabase" after review approval for migrations to take effect!

@github-actions github-actions bot added the database-change Will require migration label Feb 6, 2025
@Eddasol Eddasol force-pushed the localization-be-gone branch 2 times, most recently from 2e70e05 to 0a20db5 Compare February 6, 2025 14:39
@Eddasol Eddasol linked an issue Feb 6, 2025 that may be closed by this pull request
Remove defaultLocalisationPose from the database and stop sending startPose #1876
Closed
@Eddasol Eddasol requested a review from andchiind February 6, 2025 14:41
@Eddasol Eddasol changed the title Localization be gone Remove default localization pose Feb 6, 2025
@Eddasol Eddasol force-pushed the localization-be-gone branch from 0a20db5 to b971297 Compare February 7, 2025 06:55
@Eddasol Eddasol marked this pull request as ready for review February 7, 2025 06:56
@Eddasol Eddasol force-pushed the localization-be-gone branch 2 times, most recently from 4fe08fa to d261784 Compare February 7, 2025 07:09
@Eddasol Eddasol force-pushed the localization-be-gone branch from d261784 to 9b75c36 Compare February 7, 2025 07:15
andchiind
andchiind approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@andchiind andchiind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eddasol
Copy link
Contributor Author

Eddasol commented Feb 7, 2025

/UpdateDatabase

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2025

👀 Running migration command... 👀

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2025

✨ Successfully ran migration command! ✨

@Eddasol Eddasol merged commit 3cf832b into equinor:main Feb 7, 2025
14 checks passed
@Eddasol Eddasol deleted the localization-be-gone branch February 7, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andchiind andchiind andchiind approved these changes

Assignees
No one assigned
Labels
database-change Will require migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove defaultLocalisationPose from the database and stop sending startPose
2 participants
@Eddasol @andchiind