Fix no-unused-expressions eslint errors

equinor · Jan 17, 2025 · d4b373e · d4b373e
1 parent 3fee8e6
commit d4b373e
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 13 deletions.
diff --git a/frontend/eslint.config.js b/frontend/eslint.config.js
@@ -16,7 +16,6 @@ export default [
       "react/react-in-jsx-scope": "off",
       "react/no-unescaped-entities": "off",
       "react/display-name": "off",
-      "@typescript-eslint/no-unused-expressions": "off",
       "@typescript-eslint/no-explicit-any": "off",
     }
   }

diff --git a/frontend/src/components/Displays/MissionButtons/MissionRestartButton.tsx b/frontend/src/components/Displays/MissionButtons/MissionRestartButton.tsx
@@ -66,6 +66,11 @@ export const MissionRestartButton = ({ mission, hasFailedTasks, smallButton }: M
         setIsLocationVerificationOpen(false)
     }
 
+    const selectRerunOption = (rerunOption: ReRunOptions) => {
+        setSelectedRerunOption(rerunOption)
+        setIsLocationVerificationOpen(true)
+    }
+
     return (
         <Centered>
             <StyledButton
@@ -76,8 +81,7 @@ export const MissionRestartButton = ({ mission, hasFailedTasks, smallButton }: M
                 aria-expanded={isOpen}
                 aria-controls="menu-default"
                 onClick={() => {
-                    hasFailedTasks ? setIsOpen(!isOpen) : setSelectedRerunOption(ReRunOptions.ReRun)
-                    !hasFailedTasks && setIsLocationVerificationOpen(true)
+                    return hasFailedTasks ? setIsOpen(!isOpen) : selectRerunOption(ReRunOptions.ReRun)
                 }}
             >
                 <Icon name={smallButton ? Icons.AddOutlined : Icons.Add} size={24} />
@@ -93,17 +97,15 @@ export const MissionRestartButton = ({ mission, hasFailedTasks, smallButton }: M
                 >
                     <Menu.Item
                         onClick={() => {
-                            setSelectedRerunOption(ReRunOptions.ReRun)
-                            setIsLocationVerificationOpen(true)
+                            selectRerunOption(ReRunOptions.ReRun)
                         }}
                     >
                         {TranslateText('Rerun full mission')}
                     </Menu.Item>
                     {hasFailedTasks && (
                         <Menu.Item
                             onClick={() => {
-                                setSelectedRerunOption(ReRunOptions.ReRunFailed)
-                                setIsLocationVerificationOpen(true)
+                                selectRerunOption(ReRunOptions.ReRunFailed)
                             }}
                         >
                             {TranslateText('Rerun failed and cancelled tasks in the mission')}

diff --git a/frontend/src/components/Pages/AssetSelectionPage/AssetSelectionPage.tsx b/frontend/src/components/Pages/AssetSelectionPage/AssetSelectionPage.tsx
@@ -140,14 +140,10 @@ const InstallationPicker = () => {
                 placeholder={TranslateText('Select installation')}
                 onOptionsChange={({ selectedItems }) => {
                     const selectedName = selectedItems[0]
-                    validateInstallation(selectedName)
-                        ? setSelectedInstallation(selectedName)
-                        : setSelectedInstallation('')
+                    setSelectedInstallation(validateInstallation(selectedName) ? selectedName : '')
                 }}
                 onInput={(e: React.ChangeEvent<HTMLInputElement>) => {
-                    validateInstallation(e.target.value)
-                        ? setSelectedInstallation(e.target.value)
-                        : setSelectedInstallation('')
+                    setSelectedInstallation(validateInstallation(e.target.value) ? e.target.value : '')
                 }}
                 autoWidth={true}
                 onFocus={(e) => {