-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Fix build of linux wheel requiring cmake<3.14 #116
ci: Fix build of linux wheel requiring cmake<3.14 #116
Conversation
Since starting with CMake 3.14, only manylinux2010 compatible wheels are available, requiring any version of cmake ends building cmake from source when installed from a manylinux1 system. See scikit-build/cmake-python-distributions#76
Duplicate of #115 |
Thank you. This is a good fix while we consider building manylinux2010 images instead. |
An path forward could be to simplify the CI configuration and remove the dependency on multibuild. Similar to what was done with https://github.com/amueller/word_cloud In the mean time, I reported the following issues:
|
Does that mean that scikit-addons will provide a manylinux-compatible build environment on travis, circle or similar? |
Short answer: yes, scikit-ci-addons along with the manylinux dockcross images will simplify the overall CI pipeline. Long answer: In the case of word_cloud, the CI services are used like this:
scikit-ci-addons provides few convenience scripts to help configure environment, in the context of
All of that said, instead of appveyor (for windows wheels) and travis (for macos wheels), I suggest to improve further on what I setup for word_cloud and do the following:
At that time, Azure-Pipelines wasn't available. the manylinux environment
scikit-ci-addons is not related to manylinux, the official manylinux environment is available in the official docker image, that said I instead suggest to use the dockcross image dockcross/manylinux2010-x64 that already include ninja, cmake and scikit-build. Along with python 3.8 to test ahead of the upcoming stable release. |
Alright, excellent, then we'll surely make plans to migrate. |
Since starting with CMake 3.14, only manylinux2010 compatible wheels are
available, requiring any version of cmake ends building cmake from source
when installed from a manylinux1 system.
See scikit-build/cmake-python-distributions#76