Add possibility to navigate year picker in calendar #3571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkadiy93
requested review from
vnys,
oddvernes and
torleifhalseth
as code owners
oddvernes
requested changes
Aug 6, 2024
| }: { | ||
| setFocusedYear: (year: number) => void | ||
| year: number | ||
| yearPickerPage: number | ||
| }) => { | ||
| return ( | ||
| <Grid> | ||
| <FocusScope contain restoreFocus autoFocus> |
There was a problem hiding this comment.
With the new interactive buttons in the header, this focusScope stuff probably needs to be changed, otherwise the page changer buttons are inaccessible with keyboard. Not sure how. Perhaps FocusScope can be moved out to encompass the entire popover
oddvernes
approved these changes
Aug 26, 2024
|
All seems to be in order now 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
