feat(datepicker): Enable custom date-formats #3415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yusijs
force-pushed
the
RHENRI/date-picker-custom-format
branch
from
106b99f to
0684520
Compare
fix(datepicker): Handle external null-values
yusijs
force-pushed
the
RHENRI/date-picker-custom-format
branch
from
0684520 to
509e165
Compare
torleifhalseth
approved these changes
May 3, 2024
|
@torleifhalseth there is a short video in the issue here -> #3405 (comment) Agree on adding a note on the effect 👍 |
add comment on why we call useEffect
mhwaage
pushed a commit
to mhwaage/design-system
that referenced
this pull request
Jul 29, 2024
* feat(datepicker): Enable custom date-formats * fix(datepicker): Handle external null-values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes a bug where innerValue is used if value is null. innerValue should only be used if defaultValue is set (most likely need better logic here). Resolves #3414
Also implements a way to format the segments when they are not focused, to avoid 04/06/2024 being confusing based on user language/locale setup. This is not the solution requested, but the one that both allows for accessibility to be maintained, and allows for custom formatting. Resolves #3405