Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript error on Autocomplete #3493

Closed
magnh opened this issue Jun 5, 2024 · 1 comment · Fixed by #3515
Closed

TypeScript error on Autocomplete #3493

magnh opened this issue Jun 5, 2024 · 1 comment · Fixed by #3515
Assignees
@oddvernes
Labels
🐛 bug Something isn't working

Comments

@magnh
Copy link
Contributor

magnh commented Jun 5, 2024

Describe the bug

I get a TypeScript error when using the Autocomplete with objects as options (see repro).

Steps to reproduce the bug

Reproduction in CodeSandbox

Expected behavior

No TS errors.

Specifications

  • Version: 0.39.0
  • Browser: N/A
  • OS: N/A

Additional context

Reproduction in CodeSandbox
@magnh magnh added the 🐛 bug Something isn't working label Jun 5, 2024
@oddvernes
Copy link
Collaborator

Is this what #3487 aims to fix?

oddvernes added a commit that referenced this issue Jun 13, 2024
@oddvernes
🐛 fix for #3493, make options readonly
40423a8
@oddvernes oddvernes mentioned this issue Jun 13, 2024
Merged
@oddvernes oddvernes self-assigned this Jun 13, 2024
oddvernes added a commit that referenced this issue Jun 14, 2024
@oddvernes
🐛 Autocomplete: revert 3408 type change + readonly (#3515)
baf7e51 
* Revert changes from #3408

* 🐛 fix for #3493, make options readonly

* bump version for test release

* restore version after testrelease
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oddvernes oddvernes

Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Autocomplete: revert 3408 type change + readonly equinor/design-system
2 participants
@oddvernes @magnh