feat: Adding Port Term Based Connections examples #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
srushti-patl
commented
Feb 20, 2025
srushti-patl
commented
- Added Port 2 Port Term Based Connection
- Added Port 2 Network Based Connection
thogarty
reviewed
Feb 21, 2025
modules/port-connection/main.tf
Outdated
| @@ -151,6 +155,7 @@ resource "equinix_fabric_connection" "secondary_port_connection" { | |||
| } | |||
| order { | |||
| purchase_order_number = var.purchase_order_number != "" ? var.purchase_order_number : null | |||
| term_length = var.term_length != "" ? var.term_length: null | |||
There was a problem hiding this comment.
Because this is a number, is this the correct way to leave it out if it's the default value? Also, should the default value be 1? What are the implications of that?
There was a problem hiding this comment.
Default value is 1 for term_length so I will update this condition.
srushti-patl
force-pushed
the
CXF-108363-Term-Based-Connection-Example
branch
from
460c92d to
d19efde
Compare
thogarty
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.