Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding service token example for port and network #160

Merged
merged 3 commits into from
Dec 24, 2024

Conversation

srushti-patl
Copy link
Collaborator

  • Added Service Token Aside Port Example
  • Added Service Token Zside Port Example
  • Added Service Token Zside Network Example

Copy link
Collaborator

@thogarty thogarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the versions, shouldn't they all be at 3.1.0 because of the updated patch method on the resource? I understand that they don't all rely on the latest features added in that version, but the fix to the update method applies to all.

For the interface_id in Zside VD; I'm guessing it's not longer needed as a parameter for Service Token? They can omit and it still functions properly?

@srushti-patl
Copy link
Collaborator Author

For the versions, shouldn't they all be at 3.1.0 because of the updated patch method on the resource? I understand that they don't all rely on the latest features added in that version, but the fix to the update method applies to all.

For the interface_id in Zside VD; I'm guessing it's not longer needed as a parameter for Service Token? They can omit and it still functions properly?

we released functionality for different examples at different time but we will have to upgrade all of them to 3.1.0 version because of the patch method
interface_id is not required parameter for the request so I have removed it from the config.

@srushti-patl srushti-patl merged commit fc92c10 into main Dec 24, 2024
4 checks passed
@srushti-patl srushti-patl deleted the CXF-104049-service-token branch December 24, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants