Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Sync API Workflow Errors [java-distribution, swagger-url selection, git additions] #38

Merged
merged 6 commits into from
Feb 15, 2024

Conversation

tutkat
Copy link
Contributor

@tutkat tutkat commented Feb 15, 2024

Fixed Github Flow

  • Incorrect value for java-distribution in matrix. Needed to be in an array syntax []
  • Updated swagger hub url to point to correct line in Makefile for updates
  • Fixed git addition/committing of updated files from build

@tutkat tutkat requested a review from thogarty February 15, 2024 10:04
@tutkat tutkat force-pushed the fixSyncSdkFlowMatrix branch from 38e71e4 to c020f79 Compare February 15, 2024 11:08
@tutkat tutkat requested a review from srushti-patl February 15, 2024 17:53
@thogarty thogarty changed the title fixed flow to use java distribution - issue in structure Fixed Sync API Workflow Errors [java-distribution, swagger-url selection, git additions] Feb 15, 2024
@thogarty thogarty force-pushed the fixSyncSdkFlowMatrix branch from b9c97e5 to a85bb37 Compare February 15, 2024 19:37
@thogarty
Copy link
Contributor

Works correctly now and will successfully create new PR. Approved and merging.

Copy link
Contributor

@thogarty thogarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thogarty thogarty merged commit 186b68d into main Feb 15, 2024
4 checks passed
@thogarty thogarty deleted the fixSyncSdkFlowMatrix branch February 15, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants