Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardize vim.log.levels output #12

Merged
merged 2 commits into from
Jan 7, 2024
Merged

standardize vim.log.levels output #12

merged 2 commits into from
Jan 7, 2024

Conversation

bassamsdata
Copy link
Contributor

Just made a small commit to standardize the output of vim.log.levels.INFO and vim.log.levels.WARN. This change ensures compatibility with mini.notify, which strictly aligns with vim.notify, requiring the level parameter to be of type integer or nil. The explanation of the issue in here #640.

From the help:

vim.notify({msg}, {level}, {opts})                              *vim.notify()*
 {level}  (integer|nil) One of the values from |vim.log.levels|.

Please note that this adjustment doesn't impact other methods like vanilla vim.notify and nvim-notify.

Copy link
Owner

@epwalsh epwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bassamsdata!

@epwalsh epwalsh merged commit 7886078 into epwalsh:main Jan 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants