Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure template insertion to occur at the current line. #539

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

XiaowenHu96
Copy link
Contributor

nvim_buf_set_lines function uses zero-based indexing while nvim_win_get_cursor returns (1,0)-indexed cursor position.
This caused templates to be inserted one line below the expected cursor position.

Additionally, users were unable to customize the frontmatter in their templates due to it being placed on the second line, which was not recognized properly by obsidian.nvim. (#534)

Copy link
Owner

@epwalsh epwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @XiaowenHu96! LGTM

@epwalsh epwalsh merged commit 1265a1f into epwalsh:main Apr 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants