-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config to silent notifications and always create new notes in notes_subdir #146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @TwIStOy, thanks for the PR. I have a couple comments:
- It's not clear to me based on the name of the option what setting
never_current_dir
does. - There's a lot of places where we call
echo.info(..)
. Instead of wrapping all of those cases in anif not opts.silent
block, maybe we could add the logic withinecho
module itself?
Thanks for your review!
|
Thanks @TwIStOy, I liked how you handled |
Sounds good. Change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
No description provided.