Allow to use pathlib.Path as implicit converter #47
Conversation
|
It seems the travis build is failing because:
I can disable the |
|
Thanks for looking into it! Exact type matchesI think you should add a fallback in get_value_converter(typ) when the type is not marked as a value converter and is not directly in _implicit coverters. You could loop through _implicit_converters until one is a superclass. How would this affect paths that are specifically meant for another path system (e.g. for remote operation) ? 2.7 supportI saw that there was pathlib2 on PyPI. I'd suggest importing each of them and adding them to _implicit_converters in try blocks. Python 3.3Looks like it's time to retire it from supported versions. I'll tend to it tonight. |
|
I removed 3.3 checks from master. If you rebase your branch the build won't fail on it. |
Shir0kamii
force-pushed
the
feature/add-path-implicit-converter
branch
2 times, most recently
from
fd6f3f6 to
a45d2af
Compare
Shir0kamii
force-pushed
the
feature/add-path-implicit-converter
branch
3 times, most recently
from
97bfb37 to
5738191
Compare
|
@epsy All tests are passing! |
|
@epsy Is there anything else you might want ? |
clize/parser.py
Outdated
| try: | ||
| import pathlib2 as pathlib | ||
| except ImportError: | ||
| pathlib = False |
There was a problem hiding this comment.
You're right, the change is made
clize/parser.py
Outdated
| if getattr(annotation, '_clize__value_converter', False): | ||
| return annotation | ||
| if not isinstance(annotation, type): | ||
| annotation = type(annotation) |
There was a problem hiding this comment.
This makes it so that any callable (see line 827)'s type, instead of types themselves would be considered a converter. This seems unnecessarily broad. Is there a reason for it?
This is already the behavior for default parameters, by the way.
There was a problem hiding this comment.
I put it there because of a test not passing but it seems I misunderstood what to do.
The issubclass call expect a type as argument, and I thought an instance was being passed. Instead it was a callable that should raise a ValueError.
So instead of this, I only run the fallback if the annotation is a type.
Hi, as said during the paris.py meeting, I'm trying to solve #43 with this PR.
I tried using
pathlib.PurePathas key like you suggested, but it is not looked up since concrete objects are not of the same type.