Consider <title> for the name of its <svg> element.
#324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```html <svg> <title>My SVG</title> </svg> ``` Computing the name for this svg would have returned an empty string previously. It now correctly computes `My SVG` following the [accessible object in the accessibility tree for rendered SVG elements](https://www.w3.org/TR/svg-aam-1.0/#include_elements).
🦋 Changeset is good to goLatest commit: 07e9bf3 We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
eps1lon
requested changes
Jul 13, 2020
juanca
commented
Jul 13, 2020
sources/util.ts
Outdated
| @@ -56,6 +56,18 @@ export function isHTMLLegendElement( | |||
| return isElement(node) && node.tagName === "LEGEND"; | |||
| } | |||
|
|
|||
| export function isSVGElement(node: Node | null): node is SVGElement { | |||
| return isElement(node) && node.ownerSVGElement !== undefined; | |||
There was a problem hiding this comment.
I was getting a ts error in my IDE:
Property 'ownerSVGElement' does not exist on type 'Element'.ts(2339)
I am not sure if this is the best way to look at the defined properties -- but on SVG elements, it is either defined or null. I figured elsewhere it would be undefined.
eps1lon
reviewed
Jul 13, 2020
|
@juanca Great work, thanks! |
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Computing the name for this svg would have returned an empty string previously. It now correctly computes
My SVGfollowing the accessible object in the accessibility tree for rendered SVG elements.Closes testing-library/dom-testing-library#685