Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix url break (#35) #36

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

jm-rivera
Copy link
Contributor

Adds long_month_str to create a full month string. Modifies create_url to add logic dealing with the new url break.
Fixes #35.

Adds `long_month_str` to create a full month string.
Modifies `create_url` to add logic dealing with the new url break.
@epogrebnyak
Copy link
Owner

Thanks for submitting a PR, did you test there is any backwards compatibility? Does this mechanism work for earlier dates?

@jm-rivera
Copy link
Contributor Author

Hi - thanks for getting back to me.

Yes, tested for periods before the last 2 breaks, the previous break etc (2017, 2019, 2020, 2021, 2022, 2023), etc. It seems like when they change the structure, they don't break the permalinks for previous versions.

This PR is only addressing that break, but I think it would be good to update the packages dependencies. Let me know if I can help with that!

@epogrebnyak
Copy link
Owner

Merging, if you can update the depentencies and notch up our package version in poetry will accept as well.

Welcome to open a separate issue on SDMX endpoint. Does it provide access to all years? Can do some planning in an issue, then integrate your code in weo-reader if you would feel like it.

@epogrebnyak epogrebnyak merged commit 0bdf11d into epogrebnyak:master Apr 19, 2024
@jm-rivera jm-rivera mentioned this pull request Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: WEO download url changed again
2 participants