[BUG] Vault fails to install after changing helm to use localhost

[przemyslavic]

Describe the bug
Vault installation fails after recent changes to helm and kubectl now executed locally.

To Reproduce
Deploy a new cluster from develop branch with the configuration given below: epicli apply -f test.yml
Config files

---
kind: configuration/vault
title: Vault Config
name: default
provider: aws
specification:
  vault_enabled: true

Expected behavior
The cluster with Vault enabled has been deployed successfully

OS (please complete the following information):

• OS: [all]

Cloud Environment (please complete the following information):

• Cloud Provider [all]

Additional context
The installation fails on TASK [vault : Run configuration script] returning an error ERROR: There was an error during checking if Vault Agent Helm Chart is already installed. Exit status: 127".
Command called: helm list | grep vault; but now there is no helm on kubernetes master vm.
The role should be refactored according to the latest changes to use local helm and local kubectl.

[mkyc]

It should be dependent on https://github.com/epiphany-platform/epiphany/pull/1713/files#diff-159f36a47f14363d0d5c1a05e2504f9cR124

[erzetpe]

Yes, this is dependend on PR #1713.

[ar3ndt]

installation of Vault Helm chart needs helm binary installed on kubernetes master. I will add it.
it doesn't require helm repository itself as installation uses download_file task independently though it uses docker image from repository
quick fix already tested

[mkyc]

@rpudlowski93 isn't that task in some way already tested by you? I've seen comment in related PR.

[rpudlowski93]

@mkyc Yes, we tested it but as I noticed today morning, not enough. I found bug related to the PR and reported it here #1745.
With the change reported in the bug I tested it and it works properly, @ar3ndt should fixed it very fast (small change)

I will wait for the PR related to the #1745, and I will test finally vault using the scenario: link. If everything goes fine, I will move the task to DoD

[atsikham]

@rpudlowski93 could you please add correct dependencies to this task in dependencies section and move to correct state? It's not ready for test.

[rpudlowski93]

@atsikham - sure! It will be ready to test after marge the PR realted to #1745 :)

[rpudlowski93]

PR #1748 merged

Using the following configuation with enabled vault:

---
kind: configuration/vault
title: Vault Config
name: default
provider: azure
specification:
  vault_enabled: true

installation process finished without any errors. Helm was installed properly on master node and all necessary files were downloaded correctly from separated repository.

Tested on Azure and single master node.