Task: Prometheus Metrics - Update #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements port number as environment variable, with default, to enable running multiple sibling HMLR apps locally if needed N.B. Commented out until ruby is updated to 2.7 or greater to allow the use of the puma-metrics plugin as we're using puma 6.0.0 or greater
Adds `Middleware instrumentation` fix for 0 memory bug by notifying Action Dispatch subscribers on Prometheus initialise
Used for local development without asset compilation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR encloses all changes from ticket #449 to ensure the prometheus metrics are updated and implemented in accordance with the proposed approach contained within the Internal Wiki
Additional Changes
localmakefile target to allow for local development without asset compilation