Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes aria label issue #432

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Fixes aria label issue #432

merged 3 commits into from
Aug 28, 2024

Conversation

DanielCouzens
Copy link
Contributor

NOTE: I am unable to run locally. So this will need to be tested when in dev.

Updates the aria-label to add another location input form to meet accessibility requirements.

Please see ticket #416

Copy link
Contributor

@jonrandahl jonrandahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DanielCouzens a few points for review, also here's a screenshot of the translated area on the dev instance for reference:

CleanShot 2024-08-28 at 13 10 58

app/views/compare/show.html.haml Outdated Show resolved Hide resolved
app/views/compare/show.html.haml Outdated Show resolved Hide resolved
Copy link
Contributor

@jonrandahl jonrandahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in our meeting

Copy link
Contributor

@jonrandahl jonrandahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@DanielCouzens DanielCouzens merged commit c5be473 into dev Aug 28, 2024
2 checks passed
@DanielCouzens DanielCouzens deleted the issue/416-name-role-value branch August 28, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants