fixes aria label issue

epimorphics · Aug 28, 2024 · 87da8ab · 87da8ab
1 parent 8cad02c
commit 87da8ab
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,10 +2,10 @@
 
 ## 1.7.5 - 2024-08
 
+- (Dan) Fixed aria-label in compare locations form [GH-416](https://github.com/epimorphics/ukhpi/issues/416)
 - (Dan) Adds `aria-label` link attributes on the about page to SPARQL link
   [GH-413](https://github.com/epimorphics/ukhpi/issues/413)
 - (Bogdan) Fixed a bug where CSS was being applied to the wrong element [GH-412](https://github.com/epimorphics/ukhpi/issues/412)
-- (Bogdan) Fixed type in aria-label text [GH-416](https://github.com/epimorphics/ukhpi/issues/416)
 - (Bogdan) Fixed a duplicate character bug when selecting dates
 - (Bogdan) Added page titles for each individual view [GH-409](https://github.com/epimorphics/ukhpi/issues/409)
 - (Bogdan) Set correct values for `aria-label` link attributes on the about page

diff --git a/app/views/compare/show.html.haml b/app/views/compare/show.html.haml
@@ -47,9 +47,10 @@
                 %input{ type: 'hidden', name: 'location[]', value: location.gss }
 
             %li.c-compare__add-location
-              = t('compare.show.add_location')
-              %input{ type: 'text', name: 'location-term', value: @view_state.search_term }
-              %button{ type: 'submit', value: 'search', name: 'form-action' }
+              %label{ for: 'location-term'}
+                = t('compare.show.add_location')
+              %input{ id: 'location-term', type: 'text', name: 'location-term', "aria-label": "Location search", value: @view_state.search_term }
+              %button{ type: 'submit', value: 'search', name: 'form-action', "aria-label": "Search for location" }
                 = t('action.search')
 
           - if @view_state.search_results