Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #28 -- Update Python and Django versions #29

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

pauloxnet
Copy link
Contributor

Ref #28

@pauloxnet
Copy link
Contributor Author

@epicserve can you unlock the Python 3.7 required step and review this PR

@epicserve
Copy link
Owner

@pauloxnet, do we really need to have checks for so many permutations of Django and Python? Especially versions of Django that are no longer supported and versions of Python that are no longer supported.

@epicserve
Copy link
Owner

@pauloxnet, I'm not seeing an obvious way to unlock Python 3.7 tests from running.

@pauloxnet
Copy link
Contributor Author

@pauloxnet, do we really need to have checks for so many permutations of Django and Python? Especially versions of Django that are no longer supported and versions of Python that are no longer supported.

As for the permutations, I would leave all those Django/Python supported versions

If you are referring to Django 4.1 EOL, when I opened the PR it was still supported :-D

Python 3.8 however will still be supported until October 2024

Given today's releases, I will update this PR

@pauloxnet
Copy link
Contributor Author

@pauloxnet, I'm not seeing an obvious way to unlock Python 3.7 tests from running.

I think it's because I removed Python 3.7.

Where "un Python 3.7 tests " is defined as "required"? In the code or the repo settings?

@epicserve epicserve merged commit 3f8895b into epicserve:master Dec 4, 2023
17 checks passed
@pauloxnet
Copy link
Contributor Author

@epicserve you were faster than me. Thanks for the release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants