Adopt pyright for type checking #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #123 +/- ##
==========================================
+ Coverage 89.77% 89.78% +0.01%
==========================================
Files 23 23
Lines 1408 1449 +41
==========================================
+ Hits 1264 1301 +37
- Misses 144 148 +4 ☔ View full report in Codecov by Sentry. |
Be more explicit about defaults. The schema now says widgets can be given as None, but they will still be converted to the default even if None is passed explicitly.
These classes do not need to be serializable and the dynamic creation of generic classes does not play nicely with both pyright strict and pydantic with the current class hierarchy. This could be refactored in future to separate dynamic class creation from generic class parameterization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18