Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to Godot 4 #71

Closed
wants to merge 65 commits into from
Closed

Port to Godot 4 #71

wants to merge 65 commits into from

Conversation

Jummit
Copy link

@Jummit Jummit commented Mar 20, 2023

Runs The Intercept and Crime Scene without issues.

Tests where removed before porting. (Added back now)

There are a few tests failing which look bad, but I hope it's nothing too hard to fix.

Debatable changes:

In one commit I removed uses of self, as the GDScript style guide says not to use it if it isn't necessary.

@Jummit Jummit marked this pull request as draft March 20, 2023 11:29
@Jummit Jummit marked this pull request as ready for review March 20, 2023 11:40
@Jummit Jummit force-pushed the godot-4 branch 3 times, most recently from f9b8cff to 9a68858 Compare March 21, 2023 19:17
@ephread
Copy link
Owner

ephread commented Sep 6, 2023

Thanks for the hard work! A WIP (but usable) port to Godot 4 is now available, see #75.

@ephread ephread closed this Sep 6, 2023
@Jummit
Copy link
Author

Jummit commented Sep 7, 2023

Thanks for the hard work! A WIP (but usable) port to Godot 4 is now available, see #75.

Hell yeah! Don't worry about the lost work, it was primarily an experiment to see how far Godot 4 has come. I'm excited to use this in a future project when it's ported!

@Jummit Jummit deleted the godot-4 branch September 7, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants