Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensuring NumPy 2.0 compatibility #225

Merged
merged 9 commits into from
Jun 18, 2024
Merged

Ensuring NumPy 2.0 compatibility #225

merged 9 commits into from
Jun 18, 2024

Conversation

elinscott
Copy link
Collaborator

@elinscott elinscott commented Jun 17, 2024

Replacing np.float_, np.complex_, and other objects which were removed in NumPy 2.0

@elinscott elinscott requested a review from nscolonna June 17, 2024 09:21
@elinscott elinscott marked this pull request as draft June 17, 2024 09:26
@pep8speaks
Copy link

pep8speaks commented Jun 17, 2024

Hello @elinscott! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-06-17 13:38:42 UTC

@elinscott elinscott marked this pull request as ready for review June 18, 2024 06:50
Copy link
Collaborator

@nscolonna nscolonna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, thanks!

@elinscott elinscott merged commit 1b656f9 into master Jun 18, 2024
7 checks passed
@elinscott elinscott deleted the numpy_v2_changes branch June 18, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants