Fixed couple invalid memory access errors #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when LabelTickTime() resizes ticks.TextBuffer while last_major held pointer pointing into old now freed buffer. Fixed a warning about condition depending on uninitialized ImPlotLegend::PreviousLocation.
Ben1138
pushed a commit
to Ben1138/implot
that referenced
this pull request
Oct 2, 2024
…when LabelTickTime() resizes ticks.TextBuffer while last_major held pointer pointing into old now freed buffer. (epezent#365) Fixed a warning about condition depending on uninitialized ImPlotLegend::PreviousLocation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix freed memory read error in AddTicksTime(). Invalid read occurred when LabelTickTime() resizes ticks.TextBuffer while last_major held pointer pointing into old now freed buffer.
Fixed a warning about condition depending on uninitialized ImPlotLegend::PreviousLocation.