Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4997 - The second of three horizontal bond overlaps backbone connection line #5028

Merged
merged 5 commits into from
Jul 8, 2024

Conversation

rrodionov91
Copy link
Collaborator

@rrodionov91 rrodionov91 commented Jul 7, 2024

Also fixes #4995 - The bottom horizontal bonds does not shift if there is an overlap

How the feature works? / How did you fix the issue?

  • changed order of rendering bonds(side over backbone)
  • applied offsets for bottom part of horizontal bonds

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

…ion line

- changed order of rendering bonds(side over backbone)

#4995 - The bottom horizontal bonds does not shift if there is an overlap

- applied offsets for bottom part of horizontal bonds
Copy link
Collaborator

@AlexeyGirin AlexeyGirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@rrodionov91 rrodionov91 merged commit ed5ad1f into release/2.23 Jul 8, 2024
3 checks passed
@rrodionov91 rrodionov91 deleted the 4997-horizontal-side-connections-overlaps branch July 8, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants