#3640 - macro after reloading the page monomers added to the favorites section disappear #3688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Konstantin1996
changed the title
added 9 commits
December 14, 2023 14:12
Konstantin1996
force-pushed
the
3640-macro-after-reloading-the-page-monomers-added-to-the-favorites-section-disappear
branch
from
73b4283
to
dd47951
Compare
rrodionov91
reviewed
Dec 27, 2023
| state.favorites = localFavorites; | ||
| }, | ||
|
|
||
| unsetFavoriteMonomersFromLocalStorage: (state: RootState) => { |
There was a problem hiding this comment.
I would propose to rename it to clearFavoritesState() because this method does not unset something from local storage
| }); | ||
| }, | ||
|
|
||
| unsetFavoritePresetsFromLocalStorage: (state: RootState) => { |
| setItem: (key: string, item: unknown) => void; | ||
| } | ||
|
|
||
| class LocalStorage implements LocalStorageCopy { |
There was a problem hiding this comment.
I would propose to rename it to LocalStorageWrapper because LocalStorage can be read as native localStorage.
Also why we need interface here? Do we plan to have other classes which implement it?
rrodionov91
approved these changes
Dec 28, 2023
rrodionov91
deleted the
3640-macro-after-reloading-the-page-monomers-added-to-the-favorites-section-disappear
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
(Screenshots, videos, or GIFs, if applicable)
closes #3640
Check list
#1234 – issue name