Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macro: #3633 – undo/redo does not toggle snake mode #3682

Merged
merged 5 commits into from
Dec 12, 2023

Conversation

Nitvex
Copy link
Collaborator

@Nitvex Nitvex commented Dec 11, 2023

How the feature works? / How did you fix the issue?

(Screenshots, videos, or GIFs, if applicable)

closes #3633

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@@ -127,14 +127,17 @@ export class CoreEditor {

// todo we need to create abstraction layer for modes in future similar to the tools layer
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we can remove this comment because you created such layer

@rrodionov91 rrodionov91 merged commit 7a3657d into master Dec 12, 2023
5 checks passed
@rrodionov91 rrodionov91 deleted the 3633-macro-undoredo-does-not-toggle-snake-mode branch December 12, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Macro: undo/redo does not toggle snake mode
3 participants