Macro: #3531 – provide save/open ket and molv3000 ketcher api for macromolecules #3637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cro-provide-saveopen-ket-and-molv3000-ketcher-api-for-macromolecules
rrodionov91
approved these changes
Nov 30, 2023
| export function deleteAllEntitiesOnCanvas() { | ||
| const editor = CoreEditor.provideEditorInstance(); | ||
| const modelChanges = editor.drawingEntitiesManager.deleteAllEntities(); | ||
| editor.renderersContainer.update(modelChanges); |
There was a problem hiding this comment.
Probably we need to add changes to history also
| deserialisedKet.drawingEntitiesManager.mergeInto( | ||
| editor.drawingEntitiesManager, | ||
| ); | ||
| editor.renderersContainer.update(deserialisedKet.modelChanges); |
Closed
Nitvex
force-pushed
the
3531-macro-provide-saveopen-ket-and-molv3000-ketcher-api-for-macromolecules
branch
5 times, most recently
from
a6f58ff
to
a3e74d9
Compare
rrodionov91
approved these changes
Dec 4, 2023
README.md
Outdated
Comment on lines
104
to
105
| `setMolecule(structure: string): Promise<void>` – adds passed structure on the canvas. Current structure is not changed. | ||
| Parameters: `structure: string`. Structure is a string in any supported format. |
There was a problem hiding this comment.
Looks like it is 'addFragment', not 'setMolecule'
README.md
Outdated
| `getRxn(molfileFormat): Promise<string>` – returns `string` representation of drawn structure in RXN-format. | ||
| Parameters: `molfileFormat: 'v2000' | 'v3000'`. Optional, by default, 'v2000'. Indicates, in which format result will be returned. | ||
|
|
||
| `getKet(): Promise<string>` – returns `string` representation of drawn structure is internal Ket-format. |
There was a problem hiding this comment.
Looks like it planned to be "in internal Ket-format."
Nitvex
force-pushed
the
3531-macro-provide-saveopen-ket-and-molv3000-ketcher-api-for-macromolecules
branch
from
a3e74d9
to
5b91202
Compare
Nitvex
deleted the
3531-macro-provide-saveopen-ket-and-molv3000-ketcher-api-for-macromolecules
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
(Screenshots, videos, or GIFs, if applicable)
closes #3531
Check list
#1234 – issue name