Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3459 - All atom attributes should be displayed as SMARTS if at least one purely SMARTS attribute exists #3465

Merged
merged 7 commits into from
Oct 23, 2023
Merged

#3459 - All atom attributes should be displayed as SMARTS if at least one purely SMARTS attribute exists #3465

merged 7 commits into from
Oct 23, 2023

Conversation

AKZhuk
Copy link
Collaborator

@AKZhuk AKZhuk commented Oct 19, 2023 •
edited
Loading

How the feature works? / How did you fix the issue?

Screen.Recording.2023-10-19.at.10.53.21.mov

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@AKZhuk AKZhuk changed the title #3459 - All atom attributes should be displayed as SMARTS if at least… #3459 - All atom attributes should be displayed as SMARTS if at least one purely SMARTS attribute exists Oct 19, 2023
@AKZhuk
#3459 - All atom attributes should be displayed as SMARTS if at least…
e6d5cfa 
… one purely SMARTS attribute exists

- Update e2e snapshots
This was linked to issues Oct 19, 2023
Improve query attributes view on canvas #3327
Closed
Query properties are incorrectly presented in atom label on canvas when set up for atoms with hydrogen symbol at the end #3450
Closed
@AKZhuk
#3459 - All atom attributes should be displayed as SMARTS if at least…
c8ddb84 
… one purely SMARTS attribute exists

- Fix isotope position in custom Query
@AKZhuk
#3459 - All atom attributes should be displayed as SMARTS if at least…
44e47dd 
… one purely SMARTS attribute exists

- Fix failed tests
@AKZhuk AKZhuk linked an issue Oct 19, 2023 that may be closed by this pull request
When adding all Atom Properties from the "Query specific" section, some edges of the Template "Cycloheptane" move to the side #3424
Closed
@AKZhuk
#3459 - All atom attributes should be displayed as SMARTS if at least…
1a88db2 
… one purely SMARTS attribute exists

- Fix issue with smarts preview and  template preview
- Fix failed test
@AKZhuk
#3459 - All atom attributes should be displayed as SMARTS if at least…
047c464 
… one purely SMARTS attribute exists

- Update logic for aromaticity property
- Update snapshots
@AKZhuk AKZhuk force-pushed the 3459-all-atom-attributes-should-be-displayed-as-smarts-if-at-least-one-purely-smarts-attribute-exists branch from b0abfaa to 047c464 Compare October 20, 2023 11:16
@AKZhuk AKZhuk changed the base branch from release/smarts-enhancement to release/2.16 October 20, 2023 15:52
@AKZhuk AKZhuk linked an issue Oct 23, 2023 that may be closed by this pull request
All atom attributes should be displayed as SMARTS if at least one purely SMARTS attribute exists #3459
Closed
@Nitvex Nitvex merged commit f00faa6 into release/2.16 Oct 23, 2023
3 checks passed
@Nitvex Nitvex deleted the 3459-all-atom-attributes-should-be-displayed-as-smarts-if-at-least-one-purely-smarts-attribute-exists branch October 23, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SashaGraves SashaGraves SashaGraves approved these changes

@chgayane chgayane chgayane approved these changes

@ViktoriaTkacheva ViktoriaTkacheva ViktoriaTkacheva approved these changes

Assignees

@AKZhuk AKZhuk

Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@AKZhuk @SashaGraves @chgayane @ViktoriaTkacheva @Nitvex @Zhirnoff