Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2869 - Preview of monomer structures on canvas #3401

Merged
merged 20 commits into from
Oct 20, 2023

Conversation

OlgaMazurina
Copy link
Collaborator

@OlgaMazurina OlgaMazurina commented Oct 5, 2023

How the feature works? / How did you fix the issue?

Снимок экрана 2023-10-05 в 11 05 01 '#'

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@OlgaMazurina OlgaMazurina changed the title 2869 preview of monomer structures on canvas #2869 - Preview of monomer structures on canvas Oct 5, 2023
@OlgaMazurina OlgaMazurina linked an issue Oct 5, 2023 that may be closed by this pull request
@OlgaMazurina OlgaMazurina marked this pull request as ready for review October 5, 2023 11:54
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it intended that the screenshot shows a preview of the structure?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it intended that the screenshot shows a preview of the structure?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, here it is right

@OlgaMazurina OlgaMazurina force-pushed the 2869-Preview-of-monomer-structures-on-canvas branch 2 times, most recently from bd74aa1 to d5c3176 Compare October 10, 2023 10:14
@OlgaMazurina OlgaMazurina force-pushed the 2869-Preview-of-monomer-structures-on-canvas branch from 1ac2112 to 2ee9eaf Compare October 11, 2023 12:58
@OlgaMazurina OlgaMazurina marked this pull request as draft October 18, 2023 09:13
@OlgaMazurina OlgaMazurina force-pushed the 2869-Preview-of-monomer-structures-on-canvas branch from 35d499e to 40ba273 Compare October 18, 2023 09:37
@OlgaMazurina OlgaMazurina marked this pull request as ready for review October 18, 2023 09:39
@OlgaMazurina OlgaMazurina requested review from StarlaStarla and removed request for chgayane and MartaWilliams October 18, 2023 09:39
@rrodionov91 rrodionov91 merged commit 330b908 into master Oct 20, 2023
5 checks passed
@rrodionov91 rrodionov91 deleted the 2869-Preview-of-monomer-structures-on-canvas branch October 20, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Macro] Preview of monomer structures on canvas
5 participants