Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autotests: #2924 - test cases for functional groups and toolbar #2932

Merged
merged 7 commits into from
Oct 6, 2023

Conversation

AleksandraSmolianinova
Copy link
Collaborator

@AleksandraSmolianinova AleksandraSmolianinova commented Jul 18, 2023

How the feature works? / How did you fix the issue?

(Screenshots, videos, or GIFs, if applicable)

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"

- Added screenshots for 2 toolbar tests
…eate-autotests-for-easy-to-implement-tcses
adding new test case
@AleksandraSmolianinova AleksandraSmolianinova removed their assignment Aug 7, 2023
Copy link
Collaborator

@MartaWilliams MartaWilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to KB

Pull Request title must be exactly the same as the issue name and NEDD TO START with #task number.
Example: '#1234 Improve search performance.

@Zhirnoff Zhirnoff changed the title [Draft] 2924 create autotests for easy to implement tcses [Draft] Autotests: 2924 create autotests for easy to implement tcses Aug 8, 2023
@Zhirnoff Zhirnoff changed the title [Draft] Autotests: 2924 create autotests for easy to implement tcses Autotests: #2924 create autotests for easy to implement tcses Aug 30, 2023

test.describe('Open Ketcher', () => {
test.beforeEach(async ({ page }) => {
await page.goto('');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we replace it with waitForPageInit?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done:)

TopPanelButton,
} from '@utils';

test.describe('Open Ketcher', () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add more meaningful text for describe?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done:)

@Zhirnoff Zhirnoff changed the title Autotests: #2924 create autotests for easy to implement tcses Autotests: #2924 - test cases for functional groups and toolbar Oct 6, 2023
…eate-autotests-for-easy-to-implement-tcses
- updated screenshots
@Zhirnoff Zhirnoff merged commit dfa64a1 into master Oct 6, 2023
5 checks passed
@Zhirnoff Zhirnoff deleted the 2924-create-autotests-for-easy-to-implement-tcses branch October 6, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autotests: Сreate autotests for easy to implement TCses
5 participants