#2595 draw selection outline correctly for hovered structures #2929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iogsotot
requested review from
AleksandraSmolianinova,
Ustianskii,
Vehemen and
Zhirnoff
as code owners
Iogsotot
force-pushed
the
feature/2595-draw-selection-outline-correctly-for-hovered-structures-1
branch
from
38b3860
to
d930f16
Compare
Iogsotot
force-pushed
the
feature/2595-draw-selection-outline-correctly-for-hovered-structures-1
branch
from
9e38b9d
to
8b2434a
Compare
Nitvex
reviewed
Jul 20, 2023
|
|
||
| // 50 - shift of coordinates relative to the center, for the hover of the entire structure: | ||
| // eslint-disable-next-line no-magic-numbers | ||
| await page.mouse.move(x, y + 50, { steps: 10 }); |
There was a problem hiding this comment.
I propose to create a variable instead of comment :)
Nitvex
reviewed
Jul 20, 2023
| /* Draw selection outline correctly for hovered structures: */ | ||
| /* Arrangement by layers of structures from top to bottom: | ||
| text, bond, outline of atoms, outline of bonds, selection of atoms (with hover), selection of bonds (with hover) */ | ||
| test('Should draw selection outline correctly for hovered structures', async ({ |
There was a problem hiding this comment.
Could you add a link for github issue for this test?
Nitvex
approved these changes
Jul 20, 2023
|
Viewed |
Zhirnoff
requested changes
Jul 31, 2023
| // shift of coordinates relative to the center, for the hover of the entire structure: | ||
| const screenCenterShift = 50; | ||
|
|
||
| test.describe('Open Ketcher', () => { |
There was a problem hiding this comment.
In the general 'test.describe', you should write what that scope of autotests is automate and not 'Open Ketcher'
…/2595-draw-selection-outline-correctly-for-hovered-structures-1
Nitvex
requested review from
y-holik,
MartaWilliams and
krakmielepam
as code owners
Nitvex
force-pushed
the
feature/2595-draw-selection-outline-correctly-for-hovered-structures-1
branch
from
ddc294f
to
abdf04f
Compare
Zhirnoff
approved these changes
Aug 1, 2023
Nitvex
deleted the
feature/2595-draw-selection-outline-correctly-for-hovered-structures-1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
Closes #2595 :
implemented Possible solution
Added addition svg layers - atom, bond-skeleton
*Updated e2e tests for #2916
Before:
After:
Check list
#1234 – issue name