Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2596 Rotation tool: Use steps for increasing/decreasing the size of the rotation wheel #2611

Merged
merged 1 commit into from
May 18, 2023
Merged

#2596 Rotation tool: Use steps for increasing/decreasing the size of the rotation wheel #2611

merged 1 commit into from
May 18, 2023

Conversation

yuleicul
Copy link
Collaborator

@yuleicul yuleicul commented May 17, 2023 •
edited
Loading

Closes #2596

I tested some numbers and chose 1.4 as the factor at last.
image

Please let me know if you think 1.4 is not very suitable here.

@yuleicul yuleicul self-assigned this May 17, 2023
@auto-assign auto-assign bot requested review from Nitvex and VasilevDO May 17, 2023 07:02
@Nitvex Nitvex requested review from KonstantinEpam23 and a user May 17, 2023 07:02
@yuleicul yuleicul linked an issue May 17, 2023 that may be closed by this pull request
Rotation tool: Use steps for increasing/decreasing the size of the rotation wheel #2596
Closed
@Nitvex Nitvex changed the title #2596 Rotation tool: Use steps for increasng/decresing the size of the rotation wheel #2596 Rotation tool: Use steps for increasing/decreasing the size of the rotation wheel May 17, 2023
@yuleicul yuleicul force-pushed the 2583{checkout-from-2463}-rotation-tool-ability-to-move-the-center-of-rotation branch from ee60ce7 to fe018d1 Compare May 18, 2023 07:16
Base automatically changed from 2583{checkout-from-2463}-rotation-tool-ability-to-move-the-center-of-rotation to master May 18, 2023 07:30
@yuleicul yuleicul force-pushed the 2596{checkout-from-2583}-rotation-tool-use-steps-for-increasngdecresing-the-size-of-the-rotation-wheel branch from 2fde460 to 59e58c9 Compare May 18, 2023 07:40
@KonstantinEpam23
Copy link
Collaborator

@yuleicul I think 1.4 works quite well, thx!

@KonstantinEpam23 KonstantinEpam23 merged commit bf5cd9b into master May 18, 2023
@KonstantinEpam23 KonstantinEpam23 deleted the 2596{checkout-from-2583}-rotation-tool-use-steps-for-increasngdecresing-the-size-of-the-rotation-wheel branch May 18, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KonstantinEpam23 KonstantinEpam23 KonstantinEpam23 approved these changes

@Nitvex Nitvex Awaiting requested review from Nitvex

@VasilevDO VasilevDO Awaiting requested review from VasilevDO

Assignees

@yuleicul yuleicul

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rotation tool: Use steps for increasing/decreasing the size of the rotation wheel
2 participants
@yuleicul @KonstantinEpam23