Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rotation tool: incorrect selection box for s-groups #2624

Closed
KonstantinEpam23 opened this issue May 19, 2023 · 0 comments · Fixed by #2649 or #2674
Closed

Rotation tool: incorrect selection box for s-groups #2624

KonstantinEpam23 opened this issue May 19, 2023 · 0 comments · Fixed by #2649 or #2674
Assignees
@yuleicul
Labels
bug
Milestone
Ketcher 2.11.0-rc.2

Comments

@KonstantinEpam23
Copy link
Collaborator

Scenario 1

Steps to Reproduce

  1. Place a functional group on canvas and expand it
  2. Select the expanded s-group and contract it

Actual behavior
The selection box is still visible around the contracted s-group
Screenshot 2023-05-19 at 07 51 19

Expected behavior
Selection box is not visible for contracted s-group

Scenario 2

Steps to Reproduce

  1. Place a functional group on canvas and select it
  2. Expand the group

Actual behavior
The selection box is not visible
Screenshot 2023-05-19 at 07 51 08

Expected behavior
Selection box should be visible for expanded s-group

Ketcher version
v2.11
@KonstantinEpam23 KonstantinEpam23 added this to the Ketcher 2.12.0-rc.1 milestone May 19, 2023
yuleicul added a commit that referenced this issue May 23, 2023
@yuleicul
#2624 - Fix bounding box to rerender after expanding/contracting S-Group
e431f9e
@yuleicul yuleicul mentioned this issue May 23, 2023
Merged
@yuleicul yuleicul linked a pull request May 23, 2023 that will close this issue
Backmerge: #2624 - Rotation tool: incorrect selection box for s-groups (#2674) #2649
Merged
yuleicul added a commit that referenced this issue May 25, 2023
@yuleicul
#2624 - Fix bounding box to rerender after expanding/contracting S-Group
9795697
@yuleicul yuleicul mentioned this issue May 25, 2023
Merged
@yuleicul yuleicul linked a pull request May 25, 2023 that will close this issue
#2624 - Rotation tool: incorrect selection box for s-groups #2674
Merged
Nitvex pushed a commit that referenced this issue May 25, 2023
@yuleicul
#2624 - Fix bounding box to rerender after expanding/contracting S-Gr…
84005bb 
…oup (#2674)
Nitvex pushed a commit that referenced this issue May 25, 2023
@yuleicul
#2624 - Fix bounding box to rerender after expanding/contracting S-Gr…
beb9273 
…oup (#2649)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuleicul yuleicul

Labels
bug
Projects
None yet
Milestone
Ketcher 2.11.0-rc.2
2 participants
@yuleicul @KonstantinEpam23