Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using Template Tool, Salts and Solvents should replace Atoms, Functional Groups, and Salts and Solvents #2267

Closed
Zhirnoff opened this issue Feb 23, 2023 · 0 comments · Fixed by #2504
Closed

Using Template Tool, Salts and Solvents should replace Atoms, Functional Groups, and Salts and Solvents #2267

Zhirnoff opened this issue Feb 23, 2023 · 0 comments · Fixed by #2504
Assignees
@yuleicul
Labels
bug
Milestone
Ketcher 2.11.0-rc.1

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Feb 23, 2023 •
edited by yuleicul
Loading

Steps to Reproduce

  1. Open Ketcher
  2. Add Atom, Functional Groups, Salts and Solvents on canvas
  3. Select Salts and Solvents (e.g. formic acid) and click on Atom, Functional Groups, Salts and Solvents on canvas

Actual behavior
For an atom, an overlay occurs
For a Functional Group and a Salts and Solvents, an EDIT ABBREVIATION window appears

Expected behavior
In all cases, there must be a replacement

Screenshots

2023-02-23_18h13_07.mp4

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 109.0.5414.120 (Official Build) (64-bit)

Ketcher version
Version 2.8.0-rc.4

Additional context
Related issue: #1994
Related discussion: #2315
@Zhirnoff Zhirnoff added the bug label Feb 23, 2023
@Zhirnoff Zhirnoff added this to the Ketcher 2.9.0-rc.1 milestone Feb 23, 2023
@Zhirnoff Zhirnoff changed the title Salt and Solvents after click on an Atom, Functional Groups, Salts an Solvents not replace them After click Salts and Solvents abbreviation on an Atoms, Functional Groups, Salts an Solvents on canvas it is not replace them Mar 1, 2023
@KonstantinEpam23 KonstantinEpam23 assigned yuleicul and unassigned Nitvex Mar 17, 2023
@yuleicul yuleicul changed the title After click Salts and Solvents abbreviation on an Atoms, Functional Groups, Salts an Solvents on canvas it is not replace them Using Template Tool, Salts and Solvents should replace Atoms, Functional Groups, and Salts and Solvents Mar 20, 2023
@yuleicul yuleicul mentioned this issue Mar 20, 2023
Closed
yuleicul added a commit that referenced this issue Mar 20, 2023
@yuleicul
#2267 - Fix saltsAndSolvents to replace atoms using template tool
2996398
yuleicul added a commit that referenced this issue Mar 22, 2023
@yuleicul
#2267 - Refactor Template Tool, make it more readable
9ff8de2
yuleicul added a commit that referenced this issue Mar 22, 2023
@yuleicul
#2267 - Refactor Template Tool, add types
5ce2eec
@yuleicul yuleicul mentioned this issue Mar 22, 2023
Closed
yuleicul added a commit that referenced this issue Mar 22, 2023
@yuleicul
#2267 - Remove duplicated comments
94fd436
yuleicul added a commit that referenced this issue Apr 21, 2023
@yuleicul
#2267&#1994 - Fix Salts&Solvents to replace zero-degree structures
c361a3a
@yuleicul yuleicul mentioned this issue Apr 21, 2023
Merged
Nitvex pushed a commit that referenced this issue May 15, 2023
@yuleicul
#2267&#1994 - Fix Salts&Solvents to replace zero-degree structures (#…
d724fc1 
…2504)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuleicul yuleicul

Labels
bug
Projects
None yet
Milestone
Ketcher 2.11.0-rc.1
4 participants
@yuleicul @Nitvex @Zhirnoff @KonstantinEpam23