Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selection Tool: use rounded rectangles for selection of bonds and atom labels #2088

Closed
vanoprenko opened this issue Jan 12, 2023 · 1 comment · Fixed by #2602
Closed

Selection Tool: use rounded rectangles for selection of bonds and atom labels #2088

vanoprenko opened this issue Jan 12, 2023 · 1 comment · Fixed by #2602
Assignees
@KonstantinEpam23
Labels
feature request Priority: High
Milestone
Ketcher 2.11.0-rc.1

Comments

@vanoprenko
Copy link
Collaborator

vanoprenko commented Jan 12, 2023 •
edited
Loading

Currently selection of any atom or bond is drawn as a circle:
image

Adjust the selection rendering approach so that selected bonds and atom labels with more than 1 symbol (e.g. "OH", "CH3") are highlighted with rounded rectangles. Selection of various types of bonds should also be adjusted as highlighted below.

Bonds selections

The selection color should be adjusted:

Previous and new colors

Also hovering selected elements should be adjusted in scope of this task:

new-hover

#184121704
@KonstantinEpam23
Copy link
Collaborator

Carbon atoms that do not show their label should be selected with a circle (not like it is shown on the last screenshot)

@KonstantinEpam23 KonstantinEpam23 mentioned this issue May 12, 2023
Closed
KonstantinEpam23 added a commit that referenced this issue May 15, 2023
@KonstantinEpam23
#2088 Selection Tool: use rounded rectangles for selection of bonds a…
51e7670 
…nd atom labels
@KonstantinEpam23 KonstantinEpam23 mentioned this issue May 15, 2023
Merged
KonstantinEpam23 added a commit that referenced this issue May 16, 2023
@KonstantinEpam23
#2088 Selection Tool: use rounded rectangles for selection of bonds a…
216c45b 
…nd atom labels
KonstantinEpam23 added a commit that referenced this issue May 17, 2023
@KonstantinEpam23
#2088 Refactor, add docs
77e4f34
KonstantinEpam23 added a commit that referenced this issue May 18, 2023
@KonstantinEpam23
#2088 Refactor, fix error
c961987
KonstantinEpam23 added a commit that referenced this issue May 18, 2023
@KonstantinEpam23
#2088 Refactor, use vec2
da18570
KonstantinEpam23 added a commit that referenced this issue May 18, 2023
@KonstantinEpam23
#2088 Refactor, remove unused function
adca212
KonstantinEpam23 added a commit that referenced this issue May 19, 2023
@KonstantinEpam23
#2088 Refactor, fixes
ec36075
KonstantinEpam23 added a commit that referenced this issue May 19, 2023
@KonstantinEpam23
#2088 Refactor, fixes 2
34e44e2
KonstantinEpam23 added a commit that referenced this issue May 19, 2023
@KonstantinEpam23
#2088 Refactor, types
6ff752f
KonstantinEpam23 added a commit that referenced this issue May 19, 2023
@KonstantinEpam23
#2088 Refactor, clean
1ba405a
KonstantinEpam23 added a commit that referenced this issue May 19, 2023
@KonstantinEpam23
#2088 Refactor, use styles
3c900d6
KonstantinEpam23 added a commit that referenced this issue May 19, 2023
@KonstantinEpam23
#2088 Selection Tool: use rounded rectangles for selection of bonds a…
6ec58d3 
…nd atom labels
KonstantinEpam23 added a commit that referenced this issue May 19, 2023
@KonstantinEpam23
#2088 Selection Tool: fix bug
d41af8e
KonstantinEpam23 added a commit that referenced this issue May 19, 2023
@KonstantinEpam23
#2088 Selection Tool: fix review comments
1e19987
KonstantinEpam23 added a commit that referenced this issue May 20, 2023
@KonstantinEpam23
#2088 Selection Tool: remove unused function
f62468f
KonstantinEpam23 added a commit that referenced this issue May 22, 2023
@KonstantinEpam23
#2088 Selection Tool: update comments
596488c
KonstantinEpam23 added a commit that referenced this issue May 22, 2023
@KonstantinEpam23
#2088 Selection Tool: update pseudo atoms selection
7558370
KonstantinEpam23 added a commit that referenced this issue May 22, 2023
@KonstantinEpam23
#2088 Selection Tool: fix for single-letter atoms
0086eac
KonstantinEpam23 added a commit that referenced this issue May 22, 2023
@KonstantinEpam23
#2088 Selection Tool: put docs images into repo
dd137d8
KonstantinEpam23 added a commit that referenced this issue May 22, 2023
@KonstantinEpam23
#2088 Selection Tool: use rounded rectangles for selection of bonds a…
c8f9479 
…nd atom labels (#2602)

* #2088 Selection Tool: use rounded rectangles for selection of bonds and atom labels

* #2088 Selection Tool: fix bug

* #2088 Selection Tool: fix review comments

* #2088 Selection Tool: remove unused function

* #2088 Selection Tool: update comments

* #2088 Selection Tool: update pseudo atoms selection

* #2088 Selection Tool: fix for single-letter atoms

* #2088 Selection Tool: put docs images into repo
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KonstantinEpam23 KonstantinEpam23

Labels
feature request Priority: High
Projects
None yet
Milestone
Ketcher 2.11.0-rc.1
Development

Successfully merging a pull request may close this issue.

#2088 Selection Tool: use rounded rectangles for selection of bonds and atom labels epam/ketcher
4 participants
@vanoprenko @Nitvex @Zhirnoff @KonstantinEpam23