Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDF files are not available as part of npm ketcher-react package #1959

Closed
KonstantinEpam23 opened this issue Dec 19, 2022 · 0 comments · Fixed by #1982
Closed

SDF files are not available as part of npm ketcher-react package #1959

KonstantinEpam23 opened this issue Dec 19, 2022 · 0 comments · Fixed by #1982
Assignees
@KonstantinEpam23
Labels
feature request
Milestone
Release 2.7.0

Comments

@KonstantinEpam23
Copy link
Collaborator

KonstantinEpam23 commented Dec 19, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.
Currently *.SDF files are not included in the npm package of ketcher-react and are only available within the example ketcher application
This results in an empty list of functional groups template when you do a clean install of the application from npm

Describe the solution you'd like
We would like to have the list of all functional groups (including salts and solvents) to be available as part of the ketcher-react npm package
@KonstantinEpam23 KonstantinEpam23 added this to the Release 2.7.0 milestone Dec 19, 2022
KonstantinEpam23 added a commit that referenced this issue Dec 22, 2022
@KonstantinEpam23
#1959: SDF files are not available as part of npm ketcher-core packag
a6aa834
KonstantinEpam23 added a commit that referenced this issue Dec 22, 2022
@KonstantinEpam23
#1959: SDF files are not available as part of npm ketcher-core packag
d3ecc9d
@KonstantinEpam23 KonstantinEpam23 changed the title SDF files are not available as part of npm ketcher-core package SDF files are not available as part of npm ketcher-react package Dec 22, 2022
KonstantinEpam23 added a commit that referenced this issue Dec 22, 2022
@KonstantinEpam23
#1959: SDF files are not available as part of npm ketcher-react package
1484953
@KonstantinEpam23 KonstantinEpam23 mentioned this issue Dec 22, 2022
Merged
@KonstantinEpam23 KonstantinEpam23 linked a pull request Dec 22, 2022 that will close this issue
#1959: SDF files are not available as part of npm ketcher-react package #1982
Merged
KonstantinEpam23 added a commit that referenced this issue Dec 22, 2022
@KonstantinEpam23
#1959: SDF files are not available as part of npm ketcher-react packa…
a16ed56 
…ge (#1982)

Closes #1959
KonstantinEpam23 added a commit that referenced this issue Dec 22, 2022
@KonstantinEpam23
#1959: SDF files are not available as part of npm ketcher-react package
ee2fff0
KonstantinEpam23 added a commit that referenced this issue Dec 22, 2022
@KonstantinEpam23
Backmerge: #1959: SDF files are not available as part of npm ketcher-…
729b5fc 
…react package
KonstantinEpam23 added a commit that referenced this issue Dec 22, 2022
@KonstantinEpam23
Backmerge: #1959: SDF files are not available as part of npm ketcher-…
d9bb502 
…react package (#1983)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KonstantinEpam23 KonstantinEpam23

Labels
feature request
Projects
Ketcher
Status: Done
Milestone
Release 2.7.0
Development

Successfully merging a pull request may close this issue.

#1959: SDF files are not available as part of npm ketcher-react package epam/ketcher
2 participants
@Nitvex @KonstantinEpam23