Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hot key: Hot key "1" turns sulfur into carbon when cursor over the atom #1934

Closed
Zhirnoff opened this issue Dec 15, 2022 · 0 comments · Fixed by #2010
Closed

Hot key: Hot key "1" turns sulfur into carbon when cursor over the atom #1934

Zhirnoff opened this issue Dec 15, 2022 · 0 comments · Fixed by #2010
Assignees
@Nitvex
Labels
bug
Milestone
Release 2.7.0

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Dec 15, 2022 •
edited by vanoprenko
Loading

Bond hotkeys ("1", "2", etc.) are applied incorrectly when mouse cursor is over an atom. It is expected that corresponding type of bond is attached to the atom under cursor while previously selected tool is kept intact. Instead pressing bond hotkey leads to atom replacement with carbon.

Example:
Create a single isolated "S" atom, move mouse cursor over it and hit "1". It is expected that single bond is attached to the sulfur atom. Instead sulfur (H2S) turns into carbon (CH4).

Similar problems appear for hotkeys associated with other tools from the left toolbar.

NOTE: Hotkey "1" is currently linked to a few bond types and allows switching between them. When "1" is pressed over an atom, single bond should always be applied.
@Zhirnoff Zhirnoff added the bug label Dec 15, 2022
@Zhirnoff Zhirnoff added this to the Release 2.8.0 milestone Dec 15, 2022
@Zhirnoff Zhirnoff added the rc.3 label Dec 15, 2022
@Zhirnoff Zhirnoff modified the milestones: Release 2.8.0, Release 2.7.0 Dec 15, 2022
@Nitvex Nitvex added rc.4 and removed rc.3 labels Dec 16, 2022
@Nitvex Nitvex added rc.8 and removed rc.7 labels Dec 26, 2022
Nitvex added a commit that referenced this issue Dec 27, 2022
@Nitvex
#1934 – added handling of atom, bond, eraser and select tools, when h…
9fc6b18 
…overing over atom
Nitvex added a commit that referenced this issue Dec 27, 2022
@Nitvex
#1934 – added charge tool
2372fe6
Nitvex added a commit that referenced this issue Dec 27, 2022
@Nitvex
#1934 – added SGroup and RGroup tools
df166c2
Nitvex added a commit that referenced this issue Dec 27, 2022
@Nitvex
#1934 – added functional groups and salts and solvents handling
b5d2cdf
@Nitvex Nitvex mentioned this issue Dec 27, 2022
Merged
@Nitvex Nitvex linked a pull request Dec 27, 2022 that will close this issue
#1934 hot key hot key 1 turns sulfur into carbon when cursor over the atom #2010
Merged
Nitvex added a commit that referenced this issue Dec 28, 2022
@Nitvex
#1934 – added functional groups and salts and solvents handling
e6ddc2f
Nitvex added a commit that referenced this issue Dec 28, 2022
@Nitvex
#1934 hot key hot key 1 turns sulfur into carbon when cursor over the…
bbf9100 
… atom (#2010)

* #1934 – added handling of atom, bond, eraser and select tools, when hovering over atom

* #1934 – added charge tool

* #1934 – added SGroup and RGroup tools

* #1934 – added functional groups and salts and solvents handling
@Nitvex Nitvex closed this as completed Dec 28, 2022
Nitvex added a commit that referenced this issue Dec 28, 2022
@Nitvex
Backmerge: #1934 hot key hot key 1 turns sulfur into carbon when curs…
f3fde0d 
…or over the atom (#2010)

* #1934 – added handling of atom, bond, eraser and select tools, when hovering over atom

* #1934 – added charge tool

* #1934 – added SGroup and RGroup tools

* #1934 – added functional groups and salts and solvents handling
@Nitvex Nitvex mentioned this issue Dec 28, 2022
Merged
Nitvex added a commit that referenced this issue Dec 28, 2022
@Nitvex
Backmerge: #1934 hot key hot key 1 turns sulfur into carbon when curs…
a3e86ed 
…or over the atom (#2010) (#2014)

* #1934 – added handling of atom, bond, eraser and select tools, when hovering over atom

* #1934 – added charge tool

* #1934 – added SGroup and RGroup tools

* #1934 – added functional groups and salts and solvents handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nitvex Nitvex

Labels
bug
Projects
None yet
Milestone
Release 2.7.0
Development

Successfully merging a pull request may close this issue.

#1934 hot key hot key 1 turns sulfur into carbon when cursor over the atom epam/ketcher
3 participants
@Nitvex @Zhirnoff @KonstantinEpam23